Re: Can someone tell me what this code does ? - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: Can someone tell me what this code does ?
Date
Msg-id CAKKotZRgimD1BzVqgw4-Cutf12tUTsWtvRrvqEoDfdVS+D+0UQ@mail.gmail.com
Whole thread Raw
In response to Re: Can someone tell me what this code does ?  (Dave Cramer <davecramer@gmail.com>)
List pgadmin-hackers
Hi,

On Wed, Aug 9, 2017 at 8:19 PM, Dave Cramer <davecramer@gmail.com> wrote:
So what is the policy of the project? Ideally the cruft should be removed.

Would a patch doing so be committed?
​Yes, I guess.​

Dave Cramer

On 9 August 2017 at 00:28, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, you are correct, at a moment that's all it does.

On Tue, Aug 8, 2017 at 6:37 PM, Dave Cramer <davecramer@gmail.com> wrote:
Hi,

I guess my question was a bit vague. I get that it loads drivers. But note it does not actually put them anywhere.

First it creates a dict
sets the attribute in the app
loads the drivers dynamically
and returns an empty dict.

From what I can tell this:

DriverRegistry.load_drivers()
is all it does?





Dave Cramer

On 7 August 2017 at 23:35, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

This piece of code allow us to dynamically import all the available driver modules from '../utils/driver/' directory into our application.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

https://community.postgresrocks.net/

On Tue, Aug 8, 2017 at 4:20 AM, Dave Cramer <davecramer@gmail.com> wrote:
I'm fairly new to Python so excuse my naiveté. 

This code: in web/pgadmin/utils/driver/__init__.py  does not appear to load the drivers into the drivers dictionary ? Or am I missing something

def init_app(app):
drivers = dict()

setattr(app, '_pgadmin_server_drivers', drivers)
DriverRegistry.load_drivers()

return drivers


Dave Cramer





pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: Re: [pgAdmin4][patch] update the alert style in the sub-navigation
Next
From: Wenlin Zhang
Date:
Subject: Re: [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies