Re: Fixed RM #1209 Trigger issues through right click - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: Fixed RM #1209 Trigger issues through right click
Date
Msg-id CAKKotZRGPOigsnhTH2Yp=49dxJz+VxxBh2j7cmX3hYcw_k2CPQ@mail.gmail.com
Whole thread Raw
In response to Fixed RM #1209 Trigger issues through right click  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Akshay,

Please address below minor issues & rest of the functionality is working.
1) In case of EPAS when user updates only code definition comment is not updated along with it for from old trigger.
2) Resize the window size so that event labels in fieldset can render properly.
Refer: server_groups.js for custom dialog size (width: '650px' should work)


Thanks,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Aug 23, 2016 at 12:38 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

While fixing RM #1209 I have found following of issues, that I have fixed as part of RM #1209
  • Trigger function is not displayed in the combo box for edit mode.
  • Change the font of the "fieldset > legend" from 16px to 14px in overrides.css, as it doesn't looks good.
  • When user set constraint trigger to "Yes" then Fires should be set to "AFTER", which is fixed.
  • Code tab is always disabled and empty. User won't be able to see/update the code for PPAS when Trigger function is "Inline EDB SPL". This issue is mentioned in the RM #1209.
Attached is the patch file, please review it and let me know the review comments (if any)
  
--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: PATCH/s: RM#1387 - Bad handling of missing connection database server
Next
From: Murtuza Zabuawala
Date:
Subject: PATCH: id and pid is not being sent in response (pgAdmin4)