Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#3257] Fix for explain functionality - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][RM#3257] Fix for explain functionality
Date
Msg-id CAKKotZQwdJX6w+9OW3HoGJUBDd+3yhLhW34uR7OtScXk2-HDoQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][RM#3257] Fix for explain functionality  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Responses Re: [pgAdmin4][RM#3257] Fix for explain functionality
List pgadmin-hackers
Tree view
Thanks for reviewing Joao.

Yeah missed to run tests. I assumed its just a SQL formatting it wouldn't hurt anything but I was wrong :)
Here's updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Apr 10, 2018 at 8:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,
Looks like the tests are failing due to this change.
I also got some strange result on the linter, but I believe it is something related to this machine.

Thanks
Joao

On Tue, Apr 10, 2018 at 6:20 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

A minor fix for explain functionality.

Issue: Due to multiline explain options in the SQL template CodeMirror was failing to highlight the exact line of error.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4] Changes required to support PyCrypto
Next
From: Rahul Soshte
Date:
Subject: Ignoring web/yarn-error.log and runtime/moc_LogWindow.cpp