Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode
Date
Msg-id CAKKotZQrnW3p+sDw-0ti4_2tCVS+sx5QrJyPt6rBRp4hPAwyJQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Yes Harshal, you are right but due to RM#2922 changes now runtime is rendering the Login page.

@Dave,
Please find updated patch, which will also fix the issue of user login on each request in runtime.
RM#2952
RM#2922

--
​ ​
Murtuza

On Thu, Dec 14, 2017 at 2:25 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Murtuza,

Moving login related code from under  decorator @app.before_first_request to @app.before_request
will cause runtime user to login on each request. I think we need to find some better way.

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where we were rendering Security URL's like change password, reset password in HTML templates while running in Desktop mode, we only register these security blueprints in Server mode hence it was failing with BuildError.
RM#2952

Also reverted RM#2922 because it not working as expected and causing runtime to render login screen.


Thanks to Neel for helping me in testing the patch with latest runtime code.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: [pgAdmin4][Patch]: Allow user to select error text
Next
From: Harshal Dhumal
Date:
Subject: Re: Enums printout - possible bug