Re: PATCH: To fix salt generation in session.py - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: PATCH: To fix salt generation in session.py
Date
Msg-id CAKKotZQ+bG5P2Jmr-A93hmqps8AuRX=PTD69dOWmxgU9Q-ZQFg@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: To fix salt generation in session.py  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: PATCH: To fix salt generation in session.py  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi,

Tested, I'm able to login now.


Thanks,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Murtuza,

Can you please test this patch for the same?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Please hold on in this patch, Need additional changes.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

With latest pull session.py fails with below error with python3 because in python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', PFA patch to fix the issue.

Issue:
----------
  File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign
    self.randval = ''.join(random.sample(string.lowercase+string.digits, 20))
AttributeError: module 'string' has no attribute 'lowercase'


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: PATCH: To fix salt generation in session.py
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: [Python 3 compability] Allow to run the auto-discover