Re: Fix compiler warnings in Cube Extension - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix compiler warnings in Cube Extension
Date
Msg-id CAKJS1f_jGJ3N_rB2bHBnq3aXUYMTJR+VNQ_Mz479GEkZFpJ0mA@mail.gmail.com
Whole thread Raw
In response to Re: Fix compiler warnings in Cube Extension  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 29 December 2015 at 07:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
David Rowley <david.rowley@2ndquadrant.com> writes:
> My compiler is complaining about cube_coord() and cube_coord_llur() not
> returning a value on all code paths.

Yeah, looking at that code, this would be expected from any compiler
that doesn't know that ereport() doesn't return.  On it now.  The
documentation aspect of that commit leaves much to be desired as well.

Great. Thanks for committing.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: missing "SPI_finish" that isn't missing
Next
From: Tom Lane
Date:
Subject: Re: Avoid endless futile table locks in vacuuming.