Re: Internal error XX000 with enable_partition_pruning=on, pg 11beta1 on Debian - Mailing list pgsql-hackers

From David Rowley
Subject Re: Internal error XX000 with enable_partition_pruning=on, pg 11beta1 on Debian
Date
Msg-id CAKJS1f_e2NksDAkLNSOZQFOV3o0P_7Fo96W6+VRTxw=tDApDJA@mail.gmail.com
Whole thread Raw
In response to Re: Internal error XX000 with enable_partition_pruning=on, pg 11beta1 on Debian  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: Internal error XX000 with enable_partition_pruning=on, pg 11beta1 on Debian
List pgsql-hackers
On 18 June 2018 at 14:36, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> On 2018/06/15 20:41, David Rowley wrote:
>> If the top level Append is the UNION ALL one, then there won't be any
>> partitioned_rels. If that's what you mean by no-op then, yeah. There
>> are no duplicate locks already obtained in the parent with the child
>> Append node.
>
> Yeah, that's what I meant to say.  I looked for whether the locks end up
> being taken twice, once in the UNION ALL parent's ExecInitAppend and then
> again in the individual child Appends' ExecInitAppend, but that they
> don't, so the patch is right.

Thanks for looking.

Robert, do you have any objections to the proposed patch?

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Internal error XX000 with enable_partition_pruning=on, pg 11beta1 on Debian
Next
From: Alexander Korotkov
Date:
Subject: Re: Removing "Included attributes in B-tree indexes" section from docs