Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch to improve a few appendStringInfo* calls - Mailing list pgsql-hackers

From David Rowley
Subject Re: Patch to improve a few appendStringInfo* calls
Date
Msg-id CAKJS1f_R74sqUEvEeHNe_TDyDqqPKttKerGOyzAX=XOfQ_Nx7A@mail.gmail.com
Whole thread Raw
In response to Re: Patch to improve a few appendStringInfo* calls  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Patch to improve a few appendStringInfo* calls  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: Patch to improve a few appendStringInfo* calls  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view
On 2 July 2015 at 21:59, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
Applied the straightforward parts.

Thanks for committing.
 
I left out the changes like

-               appendStringInfoString(&collist, buf.data);
+               appendBinaryStringInfo(&collist, buf.data, buf.len);

because they're not an improvement in readablity, IMHO, and they were not in performance-critical paths.

 
Perhaps we can come up with appendStringInfoStringInfo at some later date.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Patch to improve a few appendStringInfo* calls
Next
From: Simon Riggs
Date:
Subject: Re: Let PostgreSQL's On Schedule checkpoint write buffer smooth spread cycle by tuning IsCheckpointOnSchedule?