Incorrect comment in get_partition_dispatch_recurse - Mailing list pgsql-hackers

From David Rowley
Subject Incorrect comment in get_partition_dispatch_recurse
Date
Msg-id CAKJS1f9yyimYyFzbHM4EwE+tkj4jvrHqSH0H4S4Kbas=UFpc9Q@mail.gmail.com
Whole thread Raw
Responses Re: Incorrect comment in get_partition_dispatch_recurse  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Re: Incorrect comment in get_partition_dispatch_recurse  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
I noticed that a comment in get_partition_dispatch_recurse claims that:

"it contains the
* leaf partition's position in the global list *leaf_part_oids minus 1"

The "minus 1" part is incorrect. It simply just stores the 0-based
index of the item in the list. I was going to fix it by removing just
that part, but instead, I ended up rewriting the whole thing.

Patch attached.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw withpartition wise join enabled.
Next
From: David Rowley
Date:
Subject: Re: Needless additional partition check in INSERT?