Re: [COMMITTERS] pgsql: Improve performance of timezone loading,especially pg_timezone_ - Mailing list pgsql-committers

From David Rowley
Subject Re: [COMMITTERS] pgsql: Improve performance of timezone loading,especially pg_timezone_
Date
Msg-id CAKJS1f9uYxUKJW3Ns=YMRxtNE3GWM9+aKDmW+yA0iSG1tLO=Bg@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 8 May 2017 at 02:57, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> David Rowley <david.rowley@2ndquadrant.com> writes:
>> OK, so it looks like GenerateTimezoneFiles in Install.pm for the MSVC
>> build does not quite do what make install does for src/timezone.
>> Nothing seems to pass the -p parameter as the following is doing:
>
> Ah-hah.  Still, the log message should have been there before.
> Maybe just nobody noticed?

Thanks for pushing.

The error messages were not there before. I think just load_ok would
have ended up false in tzparse(). There seems to be code to handle
that without producing any error.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Release notes for 9.6.3, 9.5.7, 9.4.12, 9.3.17, 9.2.21.
Next
From: Simon Riggs
Date:
Subject: [COMMITTERS] pgsql: Remove poorly worded and duplicated comment