Fix compiler warnings in Cube Extension - Mailing list pgsql-hackers

From David Rowley
Subject Fix compiler warnings in Cube Extension
Date
Msg-id CAKJS1f9Dw-2DwP4hPvNk3HFNSd=tFH92t79OHvEZhmtXrH5sOQ@mail.gmail.com
Whole thread Raw
Responses Re: Fix compiler warnings in Cube Extension  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

My compiler is complaining about cube_coord() and cube_coord_llur() not returning a value on all code paths.  On looking at this I noticed that this is happening due the pattern used is not quite aligned with other code, as normally we do:

if (<error condition>)
   ereport(<some error>);

do stuff;
PG_RETURN_....(value);

I've rearranged the code to be aligned more with what's normal.  In passing I also adding some missing and removed some unneeded parenthesis, and also adjusted some white space.


--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: WIP: bloom filter in Hash Joins with batches
Next
From: David Rowley
Date:
Subject: Re: WIP: bloom filter in Hash Joins with batches