On Thu, Jul 9, 2015 at 7:44 PM, David Rowley <david.rowley@2ndquadrant.com> wrote: > On 15 June 2015 at 12:05, David Rowley <david.rowley@2ndquadrant.com> wrote: >> >> >> This basically allows an aggregate's state to be shared between other >> aggregate functions when both aggregate's transition functions (and a few >> other things) match >> There's quite a number of aggregates in our standard set which will >> benefit from this optimisation. >> > > After compiling the original patch with another compiler, I noticed a couple > of warnings. > > The attached fixes these.
I did some performance tests on the patch. This patch shown good improvement for same column aggregates. With int or bigint datatype columns, this patch doesn't show any visible performance difference. But with numeric datatype it shows good improvement.
Thanks for testing this.
You should only see an improvement on aggregates listed here: