Re: pgsql: Change error handling of out of scope variables in ecpg. - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Change error handling of out of scope variables in ecpg.
Date
Msg-id CAKJS1f8N9r74qhA2LHss4Ub+-KssOwT_kK2bcFrPg1E-jWMOyA@mail.gmail.com
Whole thread Raw
In response to pgsql: Change error handling of out of scope variables in ecpg.  (Michael Meskes <meskes@postgresql.org>)
Responses Re: pgsql: Change error handling of out of scope variables in ecpg.
List pgsql-committers
On Thu, 31 Jan 2019 at 02:38, Michael Meskes <meskes@postgresql.org> wrote:
> Change error handling of out of scope variables in ecpg.
>
> The function called can result in an out of memory error that subsequently was
> disregarded. Instead it should set the appropriate SQL error variables and be
> checked by whatever whenever statement is defined.

I might be missing something here, but if you're changing the
signature of output_simple_statement(), wouldn't you also need to
change all calls to it too? ...  including the ones in preproc.y?

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Fix a crash in logical replication
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Change error handling of out of scope variables in ecpg.