Re: pgsql: Improve error reporting for DROP FUNCTION/PROCEDURE/AGGREGATE/RO - Mailing list pgsql-committers

On Sat, 23 Mar 2019 at 15:33, Andres Freund <andres@anarazel.de> wrote:
> I now get:
>
> /home/andres/src/postgresql/src/backend/parser/parse_func.c: In function ‘LookupFuncWithArgs’:
> /home/andres/src/postgresql/src/backend/parser/parse_func.c:2285:5: warning: this statement may fall through
[-Wimplicit-fallthrough=]
>      switch (objtype)
>      ^~~~~~
> /home/andres/src/postgresql/src/backend/parser/parse_func.c:2336:4: note: here
>     case FUNCLOOKUP_AMBIGUOUS:
>     ^~~~
>
> which seems like a somewhat righteous complaint? I'd just add a break to
> silence it (which can't be reached, because all paths ought to error
> out).

hmm. Surprised your compiler can't see that's not possible. I guess we
just need a break on line 2335.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services