Re: pgsql: Move strtoint() to common - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Move strtoint() to common
Date
Msg-id CAKJS1f85dabhgViVjqgo6La+Jcr6Mujor1j65O8hZX43CPjXQg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Move strtoint() to common  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Move strtoint() to common  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-committers
On 14 March 2018 at 08:10, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Move strtoint() to common
>
> Buildfarm seems to think this isn't quite baked for Windows.

Yeah, "restrict" seems to be C99, and the Microsoft compilers don't
quite know about that yet. The attached compiles fine for me on a
windows machine.

Changing "restrict" to "__restrict" also works, so it might,
longer-term, be worth some configure test and a PG_RESTICT macro so we
can allow this, assuming there are performance gains to be had.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-committers by date:

Previous
From: Michael Meskes
Date:
Subject: pgsql: Fix double frees in ecpg.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Add tests for reinit.c