Re: pg_dump multi VALUES INSERT - Mailing list pgsql-hackers

From David Rowley
Subject Re: pg_dump multi VALUES INSERT
Date
Msg-id CAKJS1f-vF0LVfsRnCCaiLe9KO_cD+u-3dBaxXueAU5ak1wHO1g@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump multi VALUES INSERT  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On Thu, 24 Jan 2019 at 04:45, Fabien COELHO <coelho@cri.ensmp.fr> wrote:

> I still do not understand the need for another variable.
>
>    int ninserts = 0; // default is to use copy
>    while (getopt...)
>    {
>      switch (...) {
>        case "--inserts":
>          if (ninserts == 0) ninserts = 1;
>          break;
>        case "--rows-per-insert":
>          ninserts = arg_value;
>          checks...
>          break;
>       ...

I didn't think of that. Attached is a version that changes it to work
along those lines.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Protect syscache from bloating with negative cache entries
Next
From: Andrew Dunstan
Date:
Subject: Re: Thread-unsafe coding in ecpg