Re: Patch to allow pg_filedump to support reading of pg_filenode.map - Mailing list pgsql-hackers

From Richard Yen
Subject Re: Patch to allow pg_filedump to support reading of pg_filenode.map
Date
Msg-id CAKH4vDhz+HCo1e+6nNyT+XZTQBY9OscqfwY=NbKfK_jxxQnKDw@mail.gmail.com
Whole thread Raw
In response to Re: Patch to allow pg_filedump to support reading of pg_filenode.map  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers


On Thu, Apr 29, 2021 at 12:05 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
I think you should be able to avoid crashing if passed a non-relmapper file.
Make sure not to loop over more mappings than exist in the relmapper file of
the given size.

I guess you should warn if the number of mappings is too large for the file's
size.  And then "cap" the number of mappings to the maximum possible number.

Ah, thanks for the tip.  That's right -- I can't assume the user's input is a valid file.  Updated patch here.

--Richard


 

--
Justin
Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: Patch to allow pg_filedump to support reading of pg_filenode.map
Next
From: Joe Conway
Date:
Subject: Re: function for testing that causes the backend to terminate