Re: Displaying chat by punished users only to themselves (db fiddle attached) - Mailing list pgsql-general

From David G. Johnston
Subject Re: Displaying chat by punished users only to themselves (db fiddle attached)
Date
Msg-id CAKFQuwbzCPTZ=4B7awiNeDAouM2fPrd2QUuH6oiDh_S=stPqBg@mail.gmail.com
Whole thread Raw
In response to Re: Displaying chat by punished users only to themselves (db fiddle attached)  (Alexander Farber <alexander.farber@gmail.com>)
Responses Re: Displaying chat by punished users only to themselves (db fiddle attached)
List pgsql-general
On Thursday, May 5, 2022, Alexander Farber <alexander.farber@gmail.com> wrote:
Good evening, I still have a problem with my JOIN expression -
when I add more games, then messages from other games are displayed:


CREATE OR REPLACE FUNCTION words_get_chat(
                in_gid   integer,
                in_uid   integer
        ) RETURNS TABLE (
                out_mine integer,
                out_game text,
                out_msg  text
        ) AS
$func$
        SELECT
                CASE WHEN c.uid = in_uid THEN 1 ELSE 0 END,
                'game #' || c.gid,
                c.msg
        FROM    words_chat c
        JOIN    words_games g USING (gid)
        JOIN    words_users opponent ON (opponent.uid IN (g.player1, g.player2) AND opponent.uid <> in_uid)
        WHERE   c.gid = in_gid
        -- always show myself my own chat messages
        AND     c.uid = in_uid
        -- otherwise only show messages by not muted opponents
        OR      NOT opponent.muted
        ORDER BY c.created ASC;

$func$ LANGUAGE sql;

I have tried making the JOIN words_users opponent even more restrictive with:

        JOIN    words_users opponent ON (opponent.uid IN (g.player1, g.player2) AND in_uid IN (g.player1, g.player2) AND opponent.uid <> in_uid)

but still messages from the game #20 are displayed, even though I pass in_gid = 10

You want:  gid and (uid or muted); what you have is: (gid and uid) or muted; based upon operator precedence.

David J.

pgsql-general by date:

Previous
From: Alexander Farber
Date:
Subject: Re: Displaying chat by punished users only to themselves (db fiddle attached)
Next
From: Alexander Farber
Date:
Subject: Re: Displaying chat by punished users only to themselves (db fiddle attached)