Re: About to add WAL write/fsync statistics to pg_stat_wal view - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: About to add WAL write/fsync statistics to pg_stat_wal view
Date
Msg-id CAKFQuwbpRk644CXZ5M_T3j3a-wb5MN-FGn5FkRQ0PvKnAmD9jg@mail.gmail.com
Whole thread Raw
In response to Re: About to add WAL write/fsync statistics to pg_stat_wal view  (Masahiro Ikeda <ikedamsh@oss.nttdata.com>)
Responses Re: About to add WAL write/fsync statistics to pg_stat_wal view  (Masahiro Ikeda <ikedamsh@oss.nttdata.com>)
List pgsql-hackers
On Mon, Jan 25, 2021 at 11:56 PM Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote:

> (wal_write)
> The number of times WAL buffers were written out to disk via XLogWrite
>

Thanks.

I thought it's better to omit "The" and "XLogWrite" because other views'
description
omits "The" and there is no description of "XlogWrite" in the documents.
What do you think?


The documentation for WAL does get into the public API level of detail and doing so here makes what this measures crystal clear.  The potential absence of sufficient detail elsewhere should be corrected instead of making this description more vague.  Specifically, probably XLogWrite should be added to the WAL overview as part of this update and probably even have the descriptive section of the documentation note that the number of times that said function is executed is exposed as a counter in the wal statistics table - thus closing the loop.

David J.

pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Re: Error on failed COMMIT
Next
From: Magnus Hagander
Date:
Subject: Re: mkid reference