Re: Event trigger code comment duplication - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Event trigger code comment duplication
Date
Msg-id CAKFQuwbiLCtOOMm52rkro5hSGZtFo-CBcQvYOVSi=bwqEB2MoQ@mail.gmail.com
Whole thread Raw
In response to Re: Event trigger code comment duplication  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, May 14, 2020 at 4:25 PM Michael Paquier <michael@paquier.xyz> wrote:
On Wed, May 13, 2020 at 04:48:59PM +0900, Michael Paquier wrote:
> Still not sure that's worth bothering.  So, let's wait a couple of
> days first to see if anybody has any comments, though I'd like to just
> go with the simplest solution at hand and remove only the duplicated
> comment about the standalone business with event triggers.

I have gone through this one again this morning, and applied the
simple version as merging the checks on the current event trigger
state would make us lose some context about why each event gets
skipped.


Ok.  Thanks!

David J.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Event trigger code comment duplication
Next
From: Tomas Vondra
Date:
Subject: Re: POC: GROUP BY optimization