Re: [PATCH] Full support for index LP_DEAD hint bits on standby - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: [PATCH] Full support for index LP_DEAD hint bits on standby
Date
Msg-id CAKFQuwbAGwG_hYA02N7wAsHro=3cxa0pytSMqZPPf+SpkjVh+g@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Full support for index LP_DEAD hint bits on standby  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Tue, Mar 29, 2022 at 5:20 PM Peter Geoghegan <pg@bowt.ie> wrote:
On Tue, Mar 29, 2022 at 4:55 AM Michail Nikolaev
<michail.nikolaev@gmail.com> wrote:

I think that you could do a better job of explaining and promoting the
problem that you're trying to solve here. Emphasis on the problem, not
so much the solution.

As a specific recommendation here - submit patches with a complete commit message.  Tweak it for each new version so that any prior discussion that informed the general design of the patch is reflected in the commit message.

This doesn't solve the "experience" issue by itself but does allow someone with interest to jump in without having to read an entire thread, including false-starts and half-ideas, to understand what the patch is doing, and why.  At the end of the day the patch should largely speak for itself, and depend minimally on the discussion thread, to be understood.

David J.

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pg_stat_reset_single_*_counters vs pg_stat_database.stats_reset
Next
From: "David G. Johnston"
Date:
Subject: Re: pg_stat_reset_single_*_counters vs pg_stat_database.stats_reset