Re: Unable parse a comment in gram.y - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Unable parse a comment in gram.y
Date
Msg-id CAKFQuwb45GhK16nfkWAb2o_6NsJ6LE9OCRG67aAemNsCZTqQbQ@mail.gmail.com
Whole thread Raw
In response to Unable parse a comment in gram.y  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: Unable parse a comment in gram.y
List pgsql-hackers
On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
I was unable to parse a comment in src/backend/parser/gram.y around line 11364:

/*
 * As func_expr but does not accept WINDOW functions directly (they
 * can still be contained in arguments for functions etc.)
 * Use this when window expressions are not allowed, so to disambiguate
 * the grammar. (e.g. in CREATE INDEX)
 */

Maybe "but" is unnecessary in the first sentence in the comment?


The "but" is required, add a comma before it.  It could also be written a bit more verbosely:

func_expr_windowless is the same as func_expr aside from not accepting window functions directly ...

David J.

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Unable parse a comment in gram.y
Next
From: Tatsuo Ishii
Date:
Subject: Re: Unable parse a comment in gram.y