Re: Cascade view drop permission checks - Mailing list pgsql-general

From David G. Johnston
Subject Re: Cascade view drop permission checks
Date
Msg-id CAKFQuwaykqdGWSQ+BSWjgr=dngYY5m5=mV+mbwwb5T3sjtfmvw@mail.gmail.com
Whole thread Raw
In response to Re: Cascade view drop permission checks  ("m7onov@gmail.com" <m7onov@gmail.com>)
List pgsql-general


On Wednesday, April 6, 2022, m7onov@gmail.com <m7onov@gmail.com> wrote:
David, thank you for the clarification.
Should we consider raising log level for cascade drops from NOTICE to WARNING? By now cascade drops appears in log files only when log level >= NOTICE.

--- a/src/backend/catalog/dependency.c
+++ b/src/backend/catalog/dependency.c
@@ -1105,7 +1105,7 @@ reportDependentObjects(const ObjectAddresses *targetObjects,
                                           int flags,
                                           const ObjectAddress *origObject)
 {
- int msglevel = (flags & PERFORM_DELETION_QUIETLY) ? DEBUG2 : NOTICE;
+ int msglevel = (flags & PERFORM_DELETION_QUIETLY) ? DEBUG2 : WARNING;
        bool ok = true;
        StringInfoData clientdetail;
        StringInfoData logdetail;

Please don’t top-post.

There is no point that I can see unless you also argue to warn/log about every dropped object.  Which can be done by the dba using event triggers if they really want to.

They said cascade and got cascade.  And can in-client set to notice and use a transaction.

David J.
 

pgsql-general by date:

Previous
From: "Thomas, Richard"
Date:
Subject: PostgreSQL 10.20 crashes / Antivirus
Next
From: Tom Lane
Date:
Subject: Re: Cascade view drop permission checks