Re: n_ins_since_vacuum stats for aborted transactions - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: n_ins_since_vacuum stats for aborted transactions
Date
Msg-id CAKFQuwavLn_axRJtiShiYHHjERj7PkY3hZM7YbpsT5YmMpsgFQ@mail.gmail.com
Whole thread Raw
In response to Re: n_ins_since_vacuum stats for aborted transactions  (Sami Imseih <samimseih@gmail.com>)
Responses Re: n_ins_since_vacuum stats for aborted transactions
List pgsql-hackers
On Fri, Apr 11, 2025 at 12:33 PM Sami Imseih <samimseih@gmail.com> wrote:

> I'm also thinking to reword n_tup_upd, something like:
>
> Total number of rows updated.  Subsets of these updates are also tracked in n_tup_hot_upd and n_tup_newpage_upd to facilitate performance monitoring.

I think the current explanation is clear enough, I am also not too
thrilled about the "...to facilitate performance monitoring." since
the cumulative stats system
as a whole is known to be used to facilitate perf monitoring.

Yeah, it was mostly a style thing - I was trying to avoid using parentheses, but the existing does make the needed point.


What do you think of the attached?


WFM.  Though is there a reason to avoid adding the "why" of the exception for n_mod_since_analyze?

David J.

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: type cache cleanup improvements
Next
From: Michael Paquier
Date:
Subject: Re: New committer: Jacob Champion