Re: doc: Clarify Savepoint Behavior - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: doc: Clarify Savepoint Behavior
Date
Msg-id CAKFQuwa+8KSNbqXxS_k1HidcAnN3vbOYMiWzUispbuCaRfKozA@mail.gmail.com
Whole thread Raw
In response to doc: Clarify Savepoint Behavior  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: doc: Clarify Savepoint Behavior
List pgsql-hackers
On Thu, Jun 9, 2022 at 8:36 AM David G. Johnston <david.g.johnston@gmail.com> wrote:
Hi,

Reposting this on its own thread.


Presently, the open item seems to be whether my novelty regarding the reworked example is too much.


Commentary:

    Per documentation comment the savepoint command lacks an example
    where the savepoint name is reused.  The suggested example didn't
    conform to the others on the page, nor did the suggested location
    in compatibility seem desirable, but the omission rang true. Add
    another example to the examples section demonstrating this case.
    Additionally, document under the description for savepoint_name
    that we allow for the name to be repeated - and note what that
    means in terms of release and rollback. It seems desirable to
    place this comment in description rather than notes for savepoint.
    For the other two commands the behavior in the presence of
    duplicate savepoint names best fits as notes.  In fact release
    already had one.  This commit copies the same verbiage over to
    rollback.

David J.

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: doc: Clarify what "excluded" represents for INSERT ON CONFLICT
Next
From: "David G. Johnston"
Date:
Subject: doc: Clarify Routines and Extension Membership