David G Johnston <david.g.johnston@gmail.com> writes: > Tom Lane-2 wrote >> Surely that was meant to read "invalid number OF arguments". The errhint >> is only charitably described as English, as well. I'd suggest something >> like "Arguments of json_build_object() must be pairs of keys and values." >> --- but maybe someone else can phrase that better.
> errmsg("argument count must be divisible by 2") > errhint("The argument list consists of alternating names and values")
Seems reasonable to me.
> Note that I s/keys/names/ to match said documentation.
Hm. The docs aren't too consistent either: there are several other nearby places that say "keys". Notably, the functions json[b]_object_keys() have that usage embedded in their names, where we can't readily change it.
I'm inclined to think we should s/names/keys/ in the docs instead. Thoughts?
Agreed - have the docs match the common API term usage in our implementation.
Not sure its worth a thorough hunt but at least fix them as they are noticed.
