Re: INFORMATION_SCHEMA.routines column routine_definition does not show the source - Mailing list pgsql-bugs

From David G. Johnston
Subject Re: INFORMATION_SCHEMA.routines column routine_definition does not show the source
Date
Msg-id CAKFQuwYT+HudtXnYTp_EvPvjd_a0516_PmmzJWX2SLQ+PLhqfg@mail.gmail.com
Whole thread Raw
In response to Re: INFORMATION_SCHEMA.routines column routine_definition does not show the source  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: INFORMATION_SCHEMA.routines column routine_definition does not show the source
List pgsql-bugs
Decided to ping this as I don't recall or see it getting patched and the recent discussion regarding the prosrc field.

On Wed, Nov 3, 2021 at 9:46 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> The information schema query consults pg_proc.prosrc directly instead of
> calling pg_get_functiondef(...) (which didn't exist when the original query
> was written, and hasn't been wrong until now).

pg_get_functiondef would produce more than we want, but it looks like
pg_get_function_sqlbody() would do.

BTW, while researching this I noted the header comment for
pg_get_functiondef:

 * Note: if you change the output format of this function, be careful not
 * to break psql's rules (in \ef and \sf) for identifying the start of the
 * function body.  To wit: the function body starts on a line that begins
 * with "AS ", and no preceding line will look like that.

Needless to say, the SQL-function-body patch has ignored this advice
totally.  At the very least this comment needs to be adjusted, but
I wonder if it's not telling us that \ef and/or \sf are broken.


pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: BUG #17704: Monitoring Queries trigger 'Signal 7: Bus Error' After Creating Hash Partitioned Table
Next
From: Tom Lane
Date:
Subject: Re: INFORMATION_SCHEMA.routines column routine_definition does not show the source