Re: ORDER BY in prepared statements - Mailing list pgsql-general

From David Johnston
Subject Re: ORDER BY in prepared statements
Date
Msg-id CAKFQuwYR5i0n=kMjkKvDTKwnWyw2F-BgO5EmOjHVpPxOuCm8PQ@mail.gmail.com
Whole thread Raw
In response to Re: ORDER BY in prepared statements  (Bryn Jeffries <bryn.jeffries@sydney.edu.au>)
Responses Re: ORDER BY in prepared statements  (David Johnston <david.g.johnston@gmail.com>)
List pgsql-general
On Wed, Jan 21, 2015 at 4:09 PM, Bryn Jeffries <bryn.jeffries@sydney.edu.au> wrote:
Paul Jungwirth wrote
> I'm not sure how to make a prepared statement that lets you name a
> column when you execute it. Maybe someone else can chime in if that's
> possible.

David J. responded
> You cannot.  By definition parameters, in this context, are values - not
> identifiers.
> [...]
> In both situations there is no way for the planner to plan and cache a
> single query whose order by column varies.  No matter what you do at best
> you can have a single plan for each explicit order by column that you wish
> to specify.

That's what I'd figured. The motivation to use prepared statements in
application layers is not so much having a single plan but more the
insulation from SQL injection. The intent of the given ORDER BY example was
to restricts inputs to valid identifiers rather than part of the query
expression.

Maybe what we need in ODBC libs and the like is a "protected
statement" that follows the same construction as a prepared statement but
additionally checks catalogs to validate identifiers.

Bryn

​The canonical way to do this, in reasonably recent PostgreSQL versions, is to wrap your desired dynamic SQL statement in a function.  Within that function construct the SQL string with the assistance of the "format(...)" function.  That function has specific placeholders for literals and identifiers that will ensure that the constructed SQL string is built in a safe manner.


Then you call the function and pass in the arguments are value parameters; which the function then converts into either literal or identifiers as instructed to by the format expression.

David J.

pgsql-general by date:

Previous
From: Bryn Jeffries
Date:
Subject: Re: ORDER BY in prepared statements
Next
From: Adrian Klaver
Date:
Subject: Re: ORDER BY in prepared statements