Re: Disabling vacuum truncate for autovacuum - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Disabling vacuum truncate for autovacuum
Date
Msg-id CAKFQuwYKtEUYKS+18gRs-xPhn0qOJgM2KGyyWVCODHuVn9F-XQ@mail.gmail.com
Whole thread Raw
In response to Re: Disabling vacuum truncate for autovacuum  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Disabling vacuum truncate for autovacuum
List pgsql-hackers
On Thu, Mar 20, 2025 at 8:18 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
Committed.


We added isset_offset to the public struct to introduce this new general behavior of tracking whether any table reloption has been set (not just vacuum_truncate) without any comments.

I get the need for this kind of logic, since we used a boolean for the table option, but as a self-proclaimed hack it seems worth more comments than provided here.  Especially pertaining to whether this is indeed generic or vacuum_truncate specific.  It's unclear since both isset and vacuum_truncate_set have been introduced.  If it is now a general property applying to any setting then vacuum_truncate_set shouldn't be needed - we should just get the isset value of the existing vacuum_truncate reloption by name.

David J.

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Adding support for SSLKEYLOGFILE in the frontend
Next
From: Andres Freund
Date:
Subject: Re: AIO v2.5