Re: xl_heap_header alignment? - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: xl_heap_header alignment?
Date
Msg-id CAKFQuwYHiojHTNmeoq57JLqCigdBLKabE+9JFg4w3X0jLCdRxQ@mail.gmail.com
Whole thread Raw
In response to xl_heap_header alignment?  (Antonin Houska <ah@cybertec.at>)
Responses Re: xl_heap_header alignment?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Fri, Aug 21, 2020 at 5:41 PM Bruce Momjian <bruce@momjian.us> wrote:
On Wed, Jul 22, 2020 at 06:58:33AM +0200, Antonin Houska wrote:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> > I don't particularly want to remove the field, but we ought to
> > change or remove the comment.
>
> I'm not concerned about the existence of the field as well. The comment just
> made me worried that I might be missing some fundamental concept. Thanks for
> your opinion.

I have developed the attached patch to address this.

I would suggest either dropping the word "potentially" or removing the sentence.  I'm not a fan of this in-between position on principle even if I don't understand the full reality of the implementation.

If leaving the word "potentially" is necessary it would be good to point out where the complexity is documented as a part of that - this header file probably not the best place to go into detail.

David J.

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Improve Managing Databases Overview Doc Page
Next
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions