Re: Correct handling of blank/commented lines in PSQL interactive-mode history - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Date
Msg-id CAKFQuwY9Z2Qk1JSduxa2ycTtFQ_Q6X6fB1zV7HrU1q1=oWxe+Q@mail.gmail.com
Whole thread Raw
In response to Correct handling of blank/commented lines in PSQL interactive-mode history  (Greg Nancarrow <gregn4422@gmail.com>)
Responses Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Re: Correct handling of blank/commented lines in PSQL interactive-mode history
List pgsql-hackers
On Mon, Sep 6, 2021 at 7:13 AM Greg Nancarrow <gregn4422@gmail.com> wrote:
I've attached a patch that corrects the behaviour.
For the type of lines mentioned, the patch makes the history behave
more like Bash history.

I have my doubts that you've really fixed anything here since Bash is a line-oriented shell while psql is a statement-oriented one.  This is a feature.

What you are observing is, I think, a side-effect of that fact that comments cannot terminate statements.  That seems reasonable.  In short, your BEFORE results make sense and don't require fixing.

David J.

pgsql-hackers by date:

Previous
From: Greg Nancarrow
Date:
Subject: Correct handling of blank/commented lines in PSQL interactive-mode history
Next
From: Alvaro Herrera
Date:
Subject: Re: Timeout failure in 019_replslot_limit.pl