Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required() - Mailing list pgsql-committers

From David G. Johnston
Subject Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()
Date
Msg-id CAKFQuwY+9NKT5XEXnvKZYma0VVKYG7MHSqfUmH5wvMdBFuGFTw@mail.gmail.com
Whole thread Raw
In response to pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()
List pgsql-committers
On Wednesday, January 16, 2019, Peter Eisentraut <peter@eisentraut.org> wrote:
Increase test coverage in RI_FKey_pk_upd_check_required()

This checks the case where the primary key has at least one null
column.

Sorry if this seems pedantic but you are testing where a unique index has at least one null column value.  A primary key, per the docs, cannot contain null in any of its columns.  I read the commit message and thought maybe that had changed while I wasn’t looking...

David J.

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Add test case for ON DELETE NO ACTION/RESTRICT
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Reorganize planner code moved in b60c39759908