Postgres Pro
Downloads
Home   >   mailing lists

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE - Mailing list pgsql-hackers

From Greg Sabino Mullane
Subject Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
Date
Msg-id CAKAnmmLOkvJ85MGyouFBr2tS+0TSZ87=t=8iaZKU25WG98nZaw@mail.gmail.com
Whole thread Raw
In response to Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE  (Nikolay Samokhvalov <samokhvalov@gmail.com>)
Responses Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
List pgsql-hackers
Tree view
I'm with Robert on this one. I'm a grudging +1 to buffers defaulting on, and a strong -1 to all the other proposals. Guillaume, the patch looks pretty good. I would like to see some of the example output have more than just "shared hit" and "read" though: let's throw some "dirtied" and "written" in there as well.

It defaults to <literal>TRUE</literal> when <literal>ANALYZE</literal> is also enabled. Otherwise, it defaults to <literal>FALSE</literal>.

Is that second sentence really needed? Because "BUFFERS ON" will never be needed anymore (save as a no-op to allow the same explain queries to run cross-version), and BUFFERS OFF outside of analyze is meaningless.

Cheers,
Greg

pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: Index AM API cleanup
Next
From: Greg Sabino Mullane
Date:
Subject: Re: sunsetting md5 password support