Postgres Pro
Downloads
Home   >   mailing lists

Re: regdatabase - Mailing list pgsql-hackers

From Greg Sabino Mullane
Subject Re: regdatabase
Date
Msg-id CAKAnmm+-AfExyXry+vC681Y884KU_cKA1kPZ09fEP2tCjWPE6g@mail.gmail.com
Whole thread Raw
In response to Re: regdatabase  (Ian Lawrence Barwick <barwick@gmail.com>)
List pgsql-hackers
Tree view
On Wed, May 7, 2025 at 4:55 AM Ian Lawrence Barwick <barwick@gmail.com> wrote:
Version which applies/builds against current HEAD attached. I haven't yet had a chance to look at the code beyond fixing it, however.

I too, have wanted this over the years, so +1 on the idea. 

Quick review: nice patch, very thorough; applies cleanly; all tests pass; acts as I would expect when testing manually.

Minor pgindent issue in the comment in src/backend/catalog/dependency.c

Would be nice to have test coverage of our special "single dash" case, e.g. 

select regdatabase('-')::oid;
0

Cheers,
Greg

--
Enterprise Postgres Software Products & Tech Support

pgsql-hackers by date:

Previous
From: Shayon Mukherjee
Date:
Subject: Re: Prolonged truncation phase during vacuum on toast table with repeated interruptions by lock waiters and a proposed POC patch
Next
From: Álvaro Herrera
Date:
Subject: Re: pg_dump does not dump domain not-null constraint's comments