On Thu, Sep 15, 2011 at 7:02 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
> On Thu, September 15, 2011 6:10 pm, Josh Kupershmidt wrote:
>> [need way to show current values]
> \! echo $foo
>
> (which is how I tested the patch, of course)
Ah, right. IMO it'd be helpful to mention that echo example in your
changes to psql-ref.sgml, either as part of your example inside the
<programlisting>, or as a suggestion with the rest of the text.
BTW, have you tested this on Windows? I don't have a Windows machine
handy to fool with, but I do see what might be a mess/confusion on
that platform. The MSDN docs claim[1] that putenv() is deprecated in
favor of _putenv(). The code in pg_upgrade uses
SetEnvironmentVariableA on WIN32, while win32env.c has a wrapper
function pgwin32_putenv() around _putenv().
On Sat, Sep 24, 2011 at 5:18 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> A description of the \setenv command should show up in the output of \?.
Yeah, Andrew agreed upthread that help.c should be amended as well,
which would fix \?.
> Should there be a regression test for this? I'm not sure how it would
> work, as I don't see a cross-platform way to see what the variable is
> set to.
Similar recent psql changes haven't had regression tests included, and
I don't see much of a need here either.
--
[1] http://msdn.microsoft.com/en-US/library/ms235321%28v=VS.80%29.aspx
Josh
