Re: Dry-run mode for pg_archivecleanup - Mailing list pgsql-hackers

From Josh Kupershmidt
Subject Re: Dry-run mode for pg_archivecleanup
Date
Msg-id CAK3UJRFdfbK43A02JqvVk5CtRQypMuh8tGhfKXj2acNS27uiUA@mail.gmail.com
Whole thread Raw
In response to Re: Dry-run mode for pg_archivecleanup  (Gabriele Bartolini <gabriele.bartolini@2ndQuadrant.it>)
Responses Re: Dry-run mode for pg_archivecleanup  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini
<gabriele.bartolini@2ndquadrant.it> wrote:

> My actual intention was to have the filename as output of the command, in
> order to easily "pipe" it to another script. Hence my first choice was to
> use the stdout channel, considering also that pg_archivecleanup in dry-run
> mode is harmless and does not touch the content of the directory.

Oh, right - I should have re-read your initial email before diving
into the patch. That all makes sense given your intended purpose. I
guess your goal of constructing some simple way to pass the files
which would be removed on to another script is a little different than
what I initially thought the patch would be useful for, namely as a
testing/debugging aid for an admin.

Perhaps both goals could be met by making use of '--debug' together
with '--dry-run'. If they are both on, then an additional message like
"pg_archivecleanup: would remove file ... " would be printed to
stderr, along with just the filename printed to stdout you already
have.

Josh


pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: Standalone synchronous master
Next
From: Ants Aasma
Date:
Subject: Re: Patch: add timing of buffer I/O requests