Postgres Pro
Downloads
Home   >   mailing lists

Re: current_logfiles not following group access and instead followslog_file_mode permissions - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: current_logfiles not following group access and instead followslog_file_mode permissions
Date
Msg-id CAJrrPGf+kOZVGet6-uCi0c7dTsckU5BdeKfGQEK4d1_Joouk8w@mail.gmail.com
Whole thread Raw
In response to Re: current_logfiles not following group access and instead followslog_file_mode permissions  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: current_logfiles not following group access and instead followslog_file_mode permissions
List pgsql-hackers
Tree view

On Thu, Mar 21, 2019 at 12:41 PM Haribabu Kommi <kommi.haribabu@gmail.com> wrote:

On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier <michael@paquier.xyz> wrote: 
And actually it seems to me that you have a race condition in that
stuff.  I think that you had better use umask(), then fopen, and then
once again umask() to put back the previous permissions, removing the
extra chmod() call.

Changed the patch to use umask() instead of chmod() according to
your suggestion.

updated patch attached.

Earlier attached patch is wrong.
Correct patch attached. Sorry for the inconvenience.

Regards,
Haribabu Kommi
Fujitsu Australia
Attachment

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: MSVC Build support with visual studio 2019
Next
From: Thomas Munro
Date:
Subject: Re: DNS SRV support for LDAP authentication