Postgres Pro
Downloads
Home   >   mailing lists

Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query
Date
Msg-id CAJrrPGdu_v6LqSg3Kt6hNiKsC9i-t_EF80OcrcDZYAa-5LPYPw@mail.gmail.com
Whole thread Raw
In response to Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query
List pgsql-hackers
Tree view

On Fri, Jul 6, 2018 at 3:22 AM Fujii Masao <masao.fujii@gmail.com> wrote:
On Wed, Jul 4, 2018 at 7:12 PM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote:
>
> Update patch attached.

+ if (userid != 0 && dbid != 0 && queryid != 0)

UINT64CONST() should be used for the constant for queryid?

OK.
 
It's rare case, but 0 can be assigned as valid queryid. Right?

But for normal queries, in post parse analyze function, the queryID
is calculated and it set to 1, in case if the calculation becomes 0.
But for the utility statements, the calculation is done using the
pgss_hash_string() function. I am not sure whether this function 
can return 0.

If yes, then we may need same handling to utility statements 
similar like normal statements but with queryID as 2 for utility statements.

comments?

Regards,
Haribabu Kommi
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: WAL prefetch
Next
From: Fabien COELHO
Date:
Subject: Re: Desirability of client-side expressions in psql?