Postgres Pro
Downloads
Home   >   mailing lists

Re: Refactor handling of database attributes betweenpg_dump and pg_dumpall - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: Refactor handling of database attributes betweenpg_dump and pg_dumpall
Date
Msg-id CAJrrPGdXP3=hjX7+N1Xa0U2VFOxf54aHqV8HR7ji3AntsXmZuA@mail.gmail.com
Whole thread Raw
In response to Re: Refactor handling of database attributes betweenpg_dump and pg_dumpall  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
Tree view


On Thu, Mar 30, 2017 at 12:00 PM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote:


On Wed, Mar 29, 2017 at 11:04 PM, Andreas Karlsson <andreas@proxel.se> wrote:
On 03/29/2017 05:43 AM, Haribabu Kommi wrote:
> Updated patch attached.

I get a test failure in the pg_upgrade tests, but I do not have time right now to investigate.

The failing test is "Restoring database schemas in the new cluster".

Thanks for test.

I found the reason for failure.

Before this refactor patch, in case of --binary-upgrade, the pg_dumpall
dumps all the global objects and also the database objects. These objects
will be restored first during the preparation of the new cluster and later
each individual database is restored.

Because of the refactoring of the database objects, currently as part of
globals dump with --binary-upgrade, no database objects gets dumped.
During restore no databases are created. so while restoring individual
database, it leads to failure as it not able to connect to the target database.

I modified the pg_upgrade code to use template1 database as a connecting
database while restoring the dump along with --create option to pg_restore
to create the database objects instead of connecting to the each individual
database.

And also while dumping the database objects, passed the new option of
--enable-pgdumpall-behaviour to pg_dump to dump the database objects
as it expected dump during pg_dumpall --binary-upgrade.

Both pg_dump and pg_upgrade tests are passed. Updated patch attached
I will add this patch to the next commitfest.

Regards,
Hari Babu
Fujitsu Australia
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: PATCH: Batch/pipelining support for libpq
Next
From: Amit Langote
Date:
Subject: Re: ANALYZE command progress checker