On Fri, Jan 12, 2018 at 03:55:04PM +1100, Haribabu Kommi wrote: > Before posting the patch, first I did the same, upon further study > I didn't find any scenario where the value is not present in > conn->connhost[conn->whichhost].host and present in conn->pghost. > > If user provides "host" as connection option, the value is present > in both the variables. Even if the connection is unix domain socket, > there is a value in conn->connhost[conn->whichhost].host. > > In case if user provides only hostaddr and host connection option, > then in that case, both the members are NULL. So even if we add > that case, it will be dead code.
Hm. Wouldn't it matter for cases where caller has not yet established a connection to the server but still calls PQhost to get the host string?
Yes I agree that the above scenario leads to a wrong result with the earlier patch,
Updated patch attached by including the conn->pghost. Thanks for the review.
