Re: Replication slot is not able to sync up - Mailing list pgsql-hackers

From shveta malik
Subject Re: Replication slot is not able to sync up
Date
Msg-id CAJpy0uBYHayRi-BpX-gKe7edFPDL8JUFwRO3Y9JW5ByorLUPjw@mail.gmail.com
Whole thread Raw
In response to Re: Replication slot is not able to sync up  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Sat, Jun 14, 2025 at 11:08 AM Amit Kapila <amit.kapila16@gmail.com> wrote:

> > I feel WARNING and CAUTION markups could be a little strong for the
> > concerned case. Such markups are generally used when there is a
> > side-effect involved with the usage. But in our case, there is no such
> > side-effect with the API. At max it may fail without harming the
> > system and will succeed in the next invocation. But I also feel that
> > such sections catch user attention. Thus if needed, we can have a NOTE
> > section to convey the recommended way of slot synchronization.
> >
>
> I think NOTE is fine for API in this case, but we can mention that the
> API is more prone to get the synchronization failure message, as you
> have shown in the patch. It would also be better to briefly explain in
> user terms why the API is more prone to such a failure.
>

Thanks Peter and Amit for feedback. I have updated the patch.

thanks
Shveta

Attachment

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Replication slot is not able to sync up
Next
From: "Matt Smith (matts3)"
Date:
Subject: [PATCH] Add an ldflags_sl meson build option