Re: Fix slot synchronization with two_phase decoding enabled - Mailing list pgsql-hackers

On Mon, Apr 28, 2025 at 4:33 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> Please find the v9 patch, addressing the above and all other comments as well.
>

Thanks for the patch.

1)

+          The default is false. This option cannot be set together with
+          <literal>two_phase</literal> when creating the slot. However, once
+          the slot is created with <literal>two_phase=true</literal>, the
+          <literal>failover</literal> can be set to true after the
+          <literal>restart_lsn</literal> has advanced beyond its
+          <literal>two_phase_at</literal> value

As the user is not aware of two_phase_at, we shall change all the docs
to have a more user friendly explanation.

2)
 # Confirm that the invalidated slot has been dropped.
 $standby1->wait_for_log(
- qr/dropped replication slot "lsub1_slot" of database with OID
[0-9]+/, $log_offset);
+ qr/dropped replication slot "lsub1_slot" of database with OID [0-9]+/,
+ $log_offset);

I think this change is not needed.

thanks
Shveta