Re: Use outerPlanState() consistently in executor code - Mailing list pgsql-hackers

From Qingqing Zhou
Subject Re: Use outerPlanState() consistently in executor code
Date
Msg-id CAJjS0u1VcA7KkKcyZcL3bJPo-4UVpLg2z=oW+c2sOCmcEUqeYw@mail.gmail.com
Whole thread Raw
In response to Re: Use outerPlanState() consistently in executor code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Use outerPlanState() consistently in executor code  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Apr 30, 2015 at 5:04 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I think I'd have done many of these as
>
> +       PlanState       *outerPlan = outerPlanState(node);
>
> rather than finding assorted random places to initialize the variables.
>

Agreed. Attached patch is revision along this line. Except for a few
that delayed assignments  does not look a random kludge, I moved most
of others together with the declaration.

Regards,
Qingqing

Attachment

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: feature freeze and beta schedule
Next
From: Andres Freund
Date:
Subject: Re: pg_dump: CREATE TABLE + CREATE RULE vs. relreplident