Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT - Mailing list pgsql-hackers

From Matheus de Oliveira
Subject Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT
Date
Msg-id CAJghg4KqiOZHG4TOxTHOhNOhyJ_NXPgHrG1eD1ySQLAvon8LFw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTERCONSTRAINT  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTERCONSTRAINT  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers


Em 3 de mar de 2018 19:32, "Peter Eisentraut" <peter.eisentraut@2ndquadrant.com> escreveu:
On 2/20/18 10:10, Matheus de Oliveira wrote:
> Besides that, there is a another change in this patch on current ALTER
> CONSTRAINT about deferrability options. Previously, if the user did
> ALTER CONSTRAINT without specifying an option on deferrable or
> initdeferred, it was implied the default options, so this:
>
>     ALTER TABLE tbl
>     ALTER CONSTRAINT con_name;
>
> Was equivalent to:
>
>     ALTER TABLE tbl
>     ALTER CONSTRAINT con_name NOT DEFERRABLE INITIALLY IMMEDIATE;

Oh, that seems wrong.  Probably, it shouldn't even accept that syntax
with an empty options list, let alone reset options that are not
mentioned.

Yeah, it felt really weird when I noticed it. And I just noticed while reading the source.

Can
you prepare a separate patch for this issue?
 
I can do that, no problem. It'll take awhile though, I'm on a trip and will be home around March 20th.

You think this should be applied to all versions that support ALTER CONSTRAINT, right?

Thanks.

Best regards,

pgsql-hackers by date:

Previous
From: Matheus de Oliveira
Date:
Subject: Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT
Next
From: Fabien COELHO
Date:
Subject: Re: csv format for psql