Re: Added schema level support for publication. - Mailing list pgsql-hackers

From Greg Nancarrow
Subject Re: Added schema level support for publication.
Date
Msg-id CAJcOf-fWMxfL6qhL1k66HZC7HXrGx7mcCpO5=CQzjn_F-ET33w@mail.gmail.com
Whole thread Raw
In response to Re: Added schema level support for publication.  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On Thu, Oct 28, 2021 at 3:25 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Thanks for committing the patch, please find the remaining patches attached.

A few comments on the v48-0002 patch:

(1) The quoting of TABLE/SCHEMA looks a bit odd in the patch comment

(2) src/backend/catalog/system_views.sq
ON should be capitalized in the following line:
+    JOIN pg_catalog.pg_namespace N on N.oid = S.pnnspid

(3) Some basic tests should be added for this in the publication tests.


Regards,
Greg Nancarrow
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Shinya Kato
Date:
Subject: Re: CREATEROLE and role ownership hierarchies
Next
From: Thomas Munro
Date:
Subject: Re: [PATCH] Make ENOSPC not fatal in semaphore creation