Re: Skipping logical replication transactions on subscriber side - Mailing list pgsql-hackers

From Greg Nancarrow
Subject Re: Skipping logical replication transactions on subscriber side
Date
Msg-id CAJcOf-fK8cExBqV0uDMvV=r+K+fydTVfO8L4Yfh4C2yX6_7ZGw@mail.gmail.com
Whole thread Raw
In response to Re: Skipping logical replication transactions on subscriber side  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Fri, Jan 21, 2022 at 2:09 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I've attached an updated patch that incorporated these commends as
> well as other comments I got so far.
>

src/backend/replication/logical/worker.c

(1)
Didn't you mean to say "check the" instead of "clear" in the following
comment? (the subtransaction's XID was never being cleared before,
just checked against the skipxid, and now that check has been removed)

+ * ...      .  Since we don't
+ * support skipping individual subtransactions we don't clear
+ * subtransaction's XID.

Other than that, the patch LGTM.

Regards,
Greg Nancarrow
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Nitin Jadhav
Date:
Subject: Re: Report checkpoint progress in server logs
Next
From: Masahiko Sawada
Date:
Subject: Re: do only critical work during single-user vacuum?