Re: PublicationActions - use bit flags. - Mailing list pgsql-hackers

From Greg Nancarrow
Subject Re: PublicationActions - use bit flags.
Date
Msg-id CAJcOf-eb1wvGCVzMBQH++ubQ3TDwwmqva0uy5w20Y2KUpWkN=A@mail.gmail.com
Whole thread Raw
In response to Re: PublicationActions - use bit flags.  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: PublicationActions - use bit flags.
List pgsql-hackers

On Tue, Jan 25, 2022 at 7:31 AM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>
> Why can't GetRelationPublicationActions() have the PublicationActions as
> a return value, instead of changing it to an output argument?

That would be OK too, for now, for the current (small size, typically 4-byte) PublicationActions struct.
But if that function was extended in the future to return more publication information than just the PublicationActions struct (and I'm seeing that in the filtering patches [1]), then using return-by-value won't be as efficient as pass-by-reference, and I'd tend to stick with pass-by-reference in that case.


Regards,
Greg Nancarrow
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication
Next
From: Amit Kapila
Date:
Subject: Re: [BUG]Update Toast data failure in logical replication