Re: unused_oids script is broken with bsd sed - Mailing list pgsql-hackers

From John Naylor
Subject Re: unused_oids script is broken with bsd sed
Date
Msg-id CAJVSVGUqEPFWxRSB0pxO5jHR83O2HF6n9Dhv51kLQuwdkuxTHQ@mail.gmail.com
Whole thread Raw
In response to Re: unused_oids script is broken with bsd sed  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: unused_oids script is broken with bsd sed  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 4/25/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> +many for rewriting in perl. Do you want to have a go at that? If not I
>> will.
>
> +1 ... I was mildly astonished that this didn't already have to happen
> as part of the bootstrap data conversion effort.  It's certainly not
> hard to imagine future extensions to the .dat file format that would
> break this script, and duplicate_oids too.  I think we should rewrite
> both of them to use the Catalog.pm infrastructure.

If we're going to use Catalog.pm for that, it seems more convenient to
expose toast and index oids directly rather than in strings formatted
specifically for the bki file, as in the attached. Thoughts?

-John Naylor

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: perltidy version
Next
From: Robert Haas
Date:
Subject: Re: wal_consistency_checking reports an inconsistency on master branch