Re: gistVacuumUpdate - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: gistVacuumUpdate
Date
Msg-id CAJKUy5iiEA-3Sq6WrObJzQrj9eTRtQB0m6_jpLRGuF3=zHHb5A@mail.gmail.com
Whole thread Raw
In response to Re: gistVacuumUpdate  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Wed, Jan 18, 2012 at 10:05 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> On 13.01.2012 06:24, YAMAMOTO Takashi wrote:
>>
>> hi,
>>
>> gistVacuumUpdate was removed when old-style VACUUM FULL was removed.
>> i wonder why.
>> it was not practical and REINDEX is preferred?
>>
>> anyway, the removal seems incomplete and there are some leftovers:
>>        F_TUPLES_DELETED
>>        F_DELETED
>>        XLOG_GIST_PAGE_DELETE
>
>
> Hmm, in theory we might bring back support for deleting pages in the future,
> I'm guessing F_DELETED and the WAL record type were left in place because of
> that.

I guess it was an oversight, because GistPageSetDeleted() is being
used in gistRedoPageDeleteRecord() and GistPageIsDeleted() in a few
other places

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación


pgsql-hackers by date:

Previous
From: Daniel Farina
Date:
Subject: Re: Inline Extension
Next
From: Jaime Casanova
Date:
Subject: Re: Measuring relation free space