Re: Declarative partitioning - another take - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: Declarative partitioning - another take
Date
Msg-id CAJGNTePfg9M9smGcWQR-WdjrnU3U5uppTwJahcD-t1pBqO1=Lw@mail.gmail.com
Whole thread Raw
In response to Re: Declarative partitioning - another take  (Jaime Casanova <jaime.casanova@2ndquadrant.com>)
Responses Re: Declarative partitioning - another take
List pgsql-hackers
On 7 November 2016 at 12:15, Jaime Casanova
<jaime.casanova@2ndquadrant.com> wrote:
> On 28 October 2016 at 02:53, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>
>> Please find attached the latest version of the patches
>
> Hi,
>
> I started to review the functionality of this patch, so i applied all
> 9 patches. After that i found this warning, which i guess is because
> it needs a cast.
>

oh! i forgot the warning
"""
partition.c: In function ‘get_qual_for_list’:
partition.c:1159:6: warning: assignment from incompatible pointer type
   or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1);
      ^
"""

attached a list of the warnings that my compiler give me (basically
most are just variables that could be used uninitialized)

--
Jaime Casanova                      www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: Declarative partitioning - another take
Next
From: Tom Lane
Date:
Subject: Re: Unsafe use of relation->rd_options without checking its type